feat: integrate Unused-Guid-Search
This integrates https://github.com/Kitzunu/Unused-Guid-Search as a tab
- Closes https://github.com/azerothcore/Keira3/issues/1288
UI Screenshot
I copied the minimal UI, and the feature supports the same tables
- UI https://github.com/Kitzunu/Unused-Guid-Search/blob/master/guid2.PNG
- tables https://github.com/Kitzunu/Unused-Guid-Search/blob/aef451e81e6c1333bd89535f41d4ed4b9931372f/UnusedGuidSearcher/SearchGuids.cs#L13
It's still missing tests and translations, but I would prefer some feedback before, as I'm not too familiar with Angular architecture
I made some minor refactoring.
We usually don't use async/await but we work with rxjs, I see that you are using firstValueFrom to avoid rxjs and use async,await. If for you it's better to work with this, you can keep it as it is.
Moreover, I see that you are using ngModel, we are using more the FormGroup and FormControls in Keira3 so I would use them, but if you want to keep everything simple as it is to speed up the development I don't mind, especially because the forms will be converted soon in "SignalForms" in Angular, so sooner or later we'll refactor them.
About other variables, I converted them into signals, and removed the cdr change detection trigger, it is not necessary if you use signals. Signals are a specific Angular features wich improve the application performances, avoid memory leak, set memorization automatically and many other features, so if possible I would still use them.
For the rest, the job seems a good start point!
@Helias, Thanks for the feedback and the improvements. I've refactored as needed to match the rest of the project, and I'lll look into setting up tests sometime in the future.