Keira3 icon indicating copy to clipboard operation
Keira3 copied to clipboard

[EPIC] Help wanted - spell_dbc editor [$25]

Open FrancescoBorzi opened this issue 3 years ago • 10 comments

I'm working on the new spell_dbc editor by taking inspiration from https://github.com/stoneharry/WoW-Spell-Editor (of course adapting it to the Keira3 look and feel, that is completely different).

I've almost finished the "ground work", but this is a big feature I need help in many EASY tasks (most of them require only a tiny little HTML knowledge).

This is how to run Keira3 in development mode: https://github.com/azerothcore/Keira3#how-to-run-keira3-in-development-mode

List of tasks per every tab:

Base tab

  • [x] Add fields
  • [x] Add unit tests
  • [ ] [EASY] add tooltips
  • [ ] [EASY] order fields in a way that they are more user-friendly
  • [ ] add selectors

Effects tab

  • [x] Add fields in their separate tabs
  • [x] Add unit tests
  • [ ] [EASY] add tooltips
  • [ ] [EASY] order fields in a way that they are more user-friendly
  • [ ] add selectors

Items tab

  • [x] Add fields
  • [x] Add unit tests
  • [ ] [EASY] add tooltips
  • [x] [EASY] order fields in a way that they are more user-friendly
  • [ ] add selectors

Flags tab

  • [x] Add fields
  • [x] Add unit tests
  • [ ] [EASY] add tooltips
  • [ ] [EASY] order fields in a way that they are more user-friendly
  • [ ] add selectors

Texts tab

  • [x] Add fields in their separate tabs
  • [x] Add unit tests

Global

to be done at the end:

  • [ ] [EASY] find out where to put the missing fields (see all fields with "TODO" spell-dbc.type.ts )
  • [x] Add integration tests

There is a $25 open bounty on this issue. Add to the bounty at Bountysource.

FrancescoBorzi avatar Apr 28 '21 17:04 FrancescoBorzi

I will take a look at this one tomorrow.

willkillson avatar May 27 '21 08:05 willkillson

@FrancescoBorzi I have been poking around and wanted to make sure I understanding what is being asked here. Please elaborate if need be, I have never used this tool and want to make sure I am successful.

[EASY] add tooltips -> Missing information in the tool tips (i) such as this, image

and none-existing tooltips such as these, image

[EASY] order fields in a way that they are more user-friendly -> Would this be fine to change the ordering to alphabetical? image

willkillson avatar May 27 '21 23:05 willkillson

I am not sure what a selector is. I see this in gossip, image

Where you click on a row and it has an indicator. The N selected / M total doesn't look like you can select multiple anything so N only changes to 1 on the first click.

willkillson avatar May 28 '21 00:05 willkillson

@willkillson

https://user-images.githubusercontent.com/1884642/119947259-72ab7580-bf8f-11eb-943b-24fe614d1c13.mp4

The-GhostRider avatar May 28 '21 07:05 The-GhostRider

@willkillson

[EASY] add tooltips -> Missing information in the tool tips (i) such as this,

yes

[EASY] order fields in a way that they are more user-friendly -> Would this be fine to change the ordering to alphabetical?

mmh no, we need to find a way that is more user friendly for people... so far we have been taking inspiration from https://github.com/stoneharry/WoW-Spell-Editor (which does not mean we should make it 100% the same)

about the rest, thanks @Stifler82 for answering with that video!

FrancescoBorzi avatar May 28 '21 10:05 FrancescoBorzi

@willkillson are you still planning to look into this?

FrancescoBorzi avatar Jun 12 '21 12:06 FrancescoBorzi

@FrancescoBorzi I am currently dealing with a move, but I plan to do this. If someone wants to take it then that's fine. Sorry, IRL is beating me up right now.

willkillson avatar Jun 12 '21 17:06 willkillson

no worries @willkillson , thanks for letting us know ;)

FrancescoBorzi avatar Jun 12 '21 21:06 FrancescoBorzi

Are the tasks here up to date?

heyitsbench avatar Jul 28 '22 06:07 heyitsbench

Are the tasks here up to date?

@heyitsbench last time I checked yes

FrancescoBorzi avatar Aug 01 '22 19:08 FrancescoBorzi