Addisu Z. Taddese

Results 636 comments of Addisu Z. Taddese

*[a discussion](https://reviewable.io/reviews/robotlocomotion/drake/16727#-N3_XfXK0XbF5l4LBn8F:-N3_j4F7E2X8VLhEMNLf:b-73blik) (no related file):* Previously, jwnimmer-tri (Jeremy Nimmer) wrote… I'm using the unit tests in this pull request to help understand what's happening in order to offer design feedback,...

*[a discussion](https://reviewable.io/reviews/robotlocomotion/drake/16727#-N3_XfXK0XbF5l4LBn8F:-N3a0EzTAtpXUhl2yU_o:b-rbwt8c) (no related file):* Previously, jwnimmer-tri (Jeremy Nimmer) wrote… OK => #17323 for further discussion. I'm okay with it, but I'd defer to @ericcousineau-tri who thought of the idea.

*[`multibody/parsing/detail_multibody_plant_subgraph.cc` line 281 at r7](https://reviewable.io/reviews/robotlocomotion/drake/16727#-N2ST8yA71JjiYjpt0L4:-N55qEyQChsV3iAIscBG:b-kxffh) ([raw file](https://github.com/robotlocomotion/drake/blob/c40c8cb31251ba5011f9ad064d5c2e49c8da5675/multibody/parsing/detail_multibody_plant_subgraph.cc#L281)):* Previously, EricCousineau-TRI (Eric Cousineau) wrote… (Just to set Reviewable's red dot) See discussion items in main thread. I've added `CloneTo` member functions to...

5856ff4 contains the example of using the MultibodyPlantSubgraph to copy a subset of a plant for use in a IK controller. The method copies the original plant and simply removes...

The `X_include_with_interface_api.sdf` files are used for testing the SDFormat [Interface API](http://sdformat.org/tutorials?tut=composition_proposal&cat=pose_semantics_docs&#1-5-minimal-libsdformat-interface-types-for-non-sdformat-models). When using this API, any element in `//include` that's not used to override the included model are passed to...

> In which version did this become allowed? Also, are there any other attributes that are allowed and should be overwritten? I believe it's been allowed since the introduction of...

I vote for closing this out and creating a new issue for addressing the number of overloads.

Thanks for the suggestions @jwnimmer-tri. This is definitely something we want to address. My initial thought is to go with the `spdlog` approach or actually add `spdlog` as a dependency....

> A parsing library has no business printing to the console in the first place -- we should always use the Error struct instead, and the caller of the parser...

> If the answer is that they should all be using the Error struct instead, with the option for the user to choose EnforcementPolicy::WARN to gloss over them, that's fine....