millet icon indicating copy to clipboard operation
millet copied to clipboard

Exception copy is buggy

Open azdavis opened this issue 2 years ago • 1 comments

Environment

  • Millet version: v0.12.2

Steps to reproduce

Given

(*!
 * Doc for A
 *)
exception A
exception B = A

Try to e.g.:

Expected behavior

It works.

Actual behavior

It doesn't.

azdavis avatar Jul 01 '23 11:07 azdavis

I believe this affects more things than just exception copy. Basically whenever in the grammar we have a name or path that is a usage site that is not directly inside exp or pat, we don’t provide jump to def for that.

This is because the current way we do jump to def is by storing information for the exp or pat idx. We don’t have a way to store jump to def info for an an arbitrary path nested in some gramma structure, such as exception copy or where type.

azdavis avatar Jul 02 '23 00:07 azdavis