Ajay Lamba

Changes are done and are out for review under https://github.com/aws-samples/aws-genai-llm-chatbot/pull/287

https://github.com/aws-samples/aws-genai-llm-chatbot/pull/287 has been merged, this issue can be closed.

@massi-ang could you please have a look?

@bigadsoleiman I have resolved the merge conflicts in the latest commit.

@spugachev I couldn't find any conflicts in the PR. I have merged the main branch. Note: I have not tested the changes after syncing with main due to some constraints...

@massi-ang It seems syncing with main has caused some unwanted changes, as the original changes were made prior to AppSync migration. I will work on this.

@massi-ang I have addressed the review comments, please have a look.

> Can you explain why there are 2 settings (Cross Encoder / Embeddings) , since if you enable embeddings models via SM, you can get Cross Encoder for free. @massi-ang...

@massi-ang I have removed the prompt for `crossEncodingEnabled` and now it is being driven from the config `enableEmbeddingModelsViaSagemaker`. The reason I still kept `crossEncodingEnabled` in the config is because similar...

@massi-ang Would you be able to have a look at this again?