zanarkand icon indicating copy to clipboard operation
zanarkand copied to clipboard

Improved error handling

Open ayyaruq opened this issue 5 years ago • 1 comments

We currently just kinda yolo return fmt.Errorf() or the occasional errors.New(). A proper set of error types should be used with wrapping to allow users to appropriately respond to different errors. Packet reassembly errors currently can't even be accessed, so that should be addressed too.

ayyaruq avatar Jan 31 '20 09:01 ayyaruq

In the reassembler's run() goroutine, using something like Trace and exposing+documenting appropriate debug flags might be a useful addition. Any reassembler errors are currently built, but not logged, due to the goroutine not having any method for output. Having a global error channel is kinda gross, but may be worthwhile.

ayyaruq avatar Jun 11 '20 07:06 ayyaruq