Albert Y. Shih

Results 181 comments of Albert Y. Shih

Ah. This isn't actually an issue with `CompositeMap`. The issue is that `GenericMap.draw_contour()` does not look for appropriate keywords in the `.plot_settings` dictionary when supplying arguments to Matplotlib's `contour()`. There...

`sunpy.physics.differential_rotation.differential_rotate()` – which still exists – is how to differentially rotate a map without using `RotatedSunFrame`. The example (https://docs.sunpy.org/en/stable/generated/gallery/differential_rotation/reprojected_map.html) does not use `differential_rotate()`. The two approaches now give the same...

Okay, I'm on board with retaining a function to download everything, but I think I'll reimplement it and give it a new name (and deprecate the old function, even though...

I don't see the benefit in providing `sunpy.download_sample_data()` since a user would still have to import `sunpy.data.sample` anyway to actually make use of the shortnames. All I was thinking was...

All comments have been addressed. There is now a rather detailed docstring for a private function. =) Someone can tell me why `autoflake` is complaining because it doesn't complain locally...

Sorry, to be clear, by "curious behavior" I meant the triggering of downloading by tab completion, not that the parfive output can go into a void when using Jupyter Notebook.

> I fixed pre-commit - see the code comment in the latest commit I pushed. Thanks! I understand now how I was running `autoflake` incorrectly. > I would like to...

> Remember you can always get the pre-commit.ci bot to fix stuff for you if you want. Heh, I continue to resist our robot overlords... =P

The "problem" is not calibration. It is that the standard LASCO data products do not subtract out the steady background of the corona. Without that additional processing step, it is...

I haven't actually run against this PR, but I suspect we don't need to make any changes in SunPy. It'll just end up that one of our frame attributes with...