Albert Y. Shih

Results 181 comments of Albert Y. Shih

> If it's being stored anywhere it belongs in a nice rst doc file. That doesn't seem practical in terms of format or maintenance. Authorship is naturally coupled with individual...

I don't necessarily have objections to authorship information being removed, but I strongly dislike the offered justifications: that Git history is a competent substitute (it isn't), and that we're too...

I still feel [this way](https://github.com/sunpy/sunpy/issues/3650#issuecomment-572075649): > I don't necessarily have objections to authorship information being removed, but I strongly dislike the offered justifications: that Git history is a competent substitute...

> Do you think authorship information is something we want to record then? Yes, I think it has value. Of course, if the authorship is tracked per file, there are...

Maybe not "happy", but I'll certainly accept a decision made by the group as long as it's not poorly justified.

Why create a new decorator instead of using our existing `deprecate_positional_args_since()`?

This is actually a bug in Sphinx after all. See sphinx-doc/sphinx#10576

I'm pretty sure `sunpy.coordinates` is all safe. I just tried using `grep` to find instances anywhere else, and the only one I can find is that SXT one. (A private...

Here's a subtle one. If you request the alternate output of `synodic` from `sunpy.physics.differential_rotation.diff_rot()`, it calculates the synodic rotation – the apparent amount of rotation for as seen by an...

Presumably this means deprecate for removal? "We" did not include me. Granted, `CompositeMap` is largely a plotting helper with a clunky API, and certainly could benefit significantly from updates. However,...