Albert Y. Shih

Results 181 comments of Albert Y. Shih

Since multiple folks have been having difficulties making the appropriate fix, clearly it was not a "good first issue" like I had thought. I have fixed it myself in #7512.

Notes for posterity: * Saving JPEG2000 images was implemented in #6153, and that PR really ought to have had the unit test verify the written output (cf. https://github.com/sunpy/sunpy/pull/6153/files#r873841948). That's an...

*Any* reprojection can be misleading if either the measured quantity is not all at exactly `rsun` (e.g., coronal structures) or the measured quantity depends on observed direction (e.g., anisotropic emission,...

Yes, that's why I used the adjective "non-source-specific". It's a shame that the suggestion to implement measurement-type map classes never caught on... My hesitation is the slippery slope if we...

Thanks, @alasdairwilson, for reminding me that I already investigated this (https://github.com/sunpy/sunpy/pull/4053#discussion_r414567660), and I concluded that the CDELT1 in the metadata is actually wrong (i.e., provides the incorrect mapping between data...

You may be new to SunPy, but hopefully you are not new to SPICE! Some terse comments: - For the from/to frames, the function should accept the SunPy version of...

Why does `slugify()` even replace periods? Periods are not typically a character that needs to be sanitized. Can we simply take periods out of the replace list? I'm not a...

It's not quite what was requested, but #7452 added the function `get_rotation_matrix()`. You'll have to manually multiply the matrix and the vector (field).

Divining the intent from the code, `slugify()` is meant to be an OS-independent sanitization, and as such, some characters are being replaced that do not need to be on some...