discordo icon indicating copy to clipboard operation
discordo copied to clipboard

Feature request: Image support

Open jrvgr opened this issue 4 years ago • 18 comments

hi i would like to see image embeds being shown in the client itself instead of needing a external viewer for it

jrvgr avatar Nov 05 '21 18:11 jrvgr

Looking into this.

DremOSDeveloperTeam avatar Feb 16 '22 17:02 DremOSDeveloperTeam

w3m ,the terminal browser does this: https://github.com/tokuhirom/w3m/blob/master/w3mimg/x11/x11_w3mimg.c edit: this is x11-only though... and depends on xterm

TheScreechingBagel avatar Mar 01 '22 17:03 TheScreechingBagel

The implementation I attempted used SIXEL instead. Most terminals still don't support this standard, but actually printing the SIXEL escape sequences to the correct location and having it scroll does not seem easy, at least to me. The code that actually downloads and translates images to SIXEL escape sequences is done, and avalible in the "images" branch on my fork (after I push what I've pulled together tonight).

DremOSDeveloperTeam avatar Mar 01 '22 19:03 DremOSDeveloperTeam

Here is a ranger issue #mentioning this:https://github.com/ranger/ranger/issues/1476 It mentions imv

TheScreechingBagel avatar Mar 01 '22 19:03 TheScreechingBagel

A Kitty based implementation with something like icat would be neat, but that would probably have to be implemented in a completely different way

KodiCraft avatar Mar 13 '22 12:03 KodiCraft

Being able to use chafa as the image backend would be nice.

emilydaemon avatar Mar 21 '22 15:03 emilydaemon

If this is implemented, it should definitely use ueberzug in my opinion. It would probably be complicated, though. For now, as a workaround, there should be a hotkey to open the link to an image in your preferred image viewer.

carterprince avatar May 24 '22 16:05 carterprince

Discordo already uses xdg-open for Linux, open for OSX and start for Windows to open attachments in the default image viewer and links in the default browser.

ayntgl avatar May 24 '22 17:05 ayntgl

6cord had sixel support then why not discordo?

rihaq avatar Aug 12 '22 19:08 rihaq

6cord had sixel support then why not discordo?

6cord actually did not have SIXEL support. As @DremOSDeveloperTeam pointed out, supporting SIXEL in something like tview is tedious work.

That said, tcell-sixel could be of use for that. foot also supports SIXEL.

diamondburned avatar Aug 23 '22 06:08 diamondburned

@diamondburned it looks pretty good. Videos could also be implemented (but it would require some work haha)

peepo5 avatar Aug 24 '22 09:08 peepo5

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

Cons-Cat avatar Sep 08 '22 16:09 Cons-Cat

6cord had sixel support then why not discordo?

6cord actually did not have SIXEL support. As @DremOSDeveloperTeam pointed out, supporting SIXEL in something like tview is tedious work.

That said, tcell-sixel could be of use for that. foot also supports SIXEL.

Who told you? Then what is this? https://github.com/diamondburned/real6cord

rihaq avatar Sep 09 '22 01:09 rihaq

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

Fuck you why are you obsessed with kitty shitty ?

rihaq avatar Sep 09 '22 01:09 rihaq

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

Fuck you why are you obsessed with kitty shitty ?

Do you honestly think that Sixel is as good as Kitty's protocol?

Cons-Cat avatar Sep 09 '22 02:09 Cons-Cat

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

Fuck you why are you obsessed with kitty shitty ?

Do you honestly think that Sixel is as good as Kitty's protocol?

Nope, I don't think sixel is good

SIXEL IS BEST

rihaq avatar Sep 09 '22 03:09 rihaq

Animated images that can move in a terminal efficiently is precisely what the Kitty graphics protocol was invented to do.

Fuck you why are you obsessed with kitty shitty ?

Do you honestly think that Sixel is as good as Kitty's protocol?

You need a dose of copium

rihaq avatar Sep 09 '22 03:09 rihaq

Who told you? Then what is this? https://github.com/diamondburned/real6cord

It's garbage that does not work :upside_down_face:

Try asking the developer and see what they have to say about it.

P/S: I'm not going to babysit this issue (it's not my issue), but I would much rather we maintain a constructive tone rather than yelling "dose of copium" at someone else. I don't think that's at all productive or helpful to anyone.

diamondburned avatar Sep 09 '22 05:09 diamondburned