Ayman Habib
Ayman Habib
All changes requested have been implemented in addition a test for ellipse perimeter length was added. Ready for review. Maybe good for @nickbianco to take a look and give feedback...
> > _[Reviewable](https://reviewable.io/reviews/opensim-org/opensim-core/3284)_ status: all files reviewed, 16 unresolved discussions (waiting on @aymanhab and @carmichaelong) > > _[`OpenSim/Simulation/Model/PathSpring.h` line 146 at r6](https://reviewable.io/reviews/opensim-org/opensim-core/3284#-NMArvUC93pCFCUVfE5p:-NMBCZ_TAVreAMs52XTh:biu29lw) ([raw file](https://github.com/opensim-org/opensim-core/blob/97482af156bdfc0a6df767943740ecb7f7325ff4/OpenSim/Simulation/Model/PathSpring.h#L146)):_ > > Previously, nickbianco (Nicholas Bianco)...
> In `testCompareWrapObjects`, the wrap objects are intersecting, which could be causing wrapping issues for certain configurations of the cylinder. > >  > > >...
> > _[Reviewable](https://reviewable.io/reviews/opensim-org/opensim-core/3284)_ status: all files reviewed, 16 unresolved discussions (waiting on @aymanhab and @carmichaelong) > > _[`OpenSim/Tests/Wrapping/testWrappingAlgorithm.cpp` line 124 at r6](https://reviewable.io/reviews/opensim-org/opensim-core/3284#-NMBZl_z-iCiqccPGBOG:-NMBZl_z-iCiqccPGBOH:belgt4m) ([raw file](https://github.com/opensim-org/opensim-core/blob/97482af156bdfc0a6df767943740ecb7f7325ff4/OpenSim/Tests/Wrapping/testWrappingAlgorithm.cpp#L124)):_ > > > ```c++ > >...
> > _[Reviewable](https://reviewable.io/reviews/opensim-org/opensim-core/3284)_ status: all files reviewed, 16 unresolved discussions (waiting on @aymanhab and @carmichaelong) > > _[`OpenSim/Tests/Wrapping/testWrappingAlgorithm.cpp` line 124 at r6](https://reviewable.io/reviews/opensim-org/opensim-core/3284#-NMBZl_z-iCiqccPGBOG:-NMFJc1_-YgL_SwU0s79:b-yzknqs) ([raw file](https://github.com/opensim-org/opensim-core/blob/97482af156bdfc0a6df767943740ecb7f7325ff4/OpenSim/Tests/Wrapping/testWrappingAlgorithm.cpp#L124)):_ > > Previously, aymanhab (Ayman Habib)...
The benefit is that other test cases all test perpendicular wrapping and the other analytical case only spot checks when wrapping curve is a quarter of an ellipse, but I...
Merging per discussion with @nickbianco Thanks @nickbianco and @carmichaelong for the excellent review 👍
Build succeeds with osx-11 but fails to load/run without library path setting, PR in the pipe https://github.com/opensim-org/opensim-gui/pull/1389
Done a while ago, closing
I'll merge this since it only affects ci by adding osx11 build, and will allow us to test the fix to #3334