ayeteadoe

Results 54 comments of ayeteadoe

**Update:** My investigation was already discovered in https://github.com/LadybirdBrowser/ladybird/pull/3549 and discussed in discord. So the following is nothing new, but just leaving it here for future reference. UAF issue when `test-web`...

Update: Going to wait until https://github.com/LadybirdBrowser/ladybird/pull/4667 is merged so I can roll the Windows adjustments into this as well (I need the export symbol stuff for that), as it is...

> should we use sigsetjmp instead? We can do that for the POSIX platforms, but Windows only has the standard lirbary `set/longjmp`. > is there a way for the 'windows'...

> is there a way for the 'windows' way to happen at link time Update: The answer is yes, I now have that working locally, so one more rebase incoming

> your latest push overrode the changes from https://github.com/LadybirdBrowser/ladybird/commit/38714fd93765a1789b966c93e975ef34c688f4b4. 😬 My bad! Yeah I did not pull down your changes first, I typically submit pull requests again the branch and...

Oh, `EXPECT_DEATH` as well is now not working on Windows, one sec

`__declspec(selectany)` is not as smart as `[[gnu::weak]]`, `AK` still has to explicitly link with our customized `ak_assertion_handler` in `AssertionHandler.cpp` for it to actually select our symbol at link time, otherwise...

> It linked just fine on my machine. Let's figure out why instead of linking AK to LibTest Do you still have a working local copy? If so if you...

Ah yeah, an approach I could see would be the first backend that `LibWebGPU` or `LibGfx/WebGPU` (not sure which location is ideal) would implement would be Dawn. Then Metal/Vulkan backends...