xorf

xorf copied to clipboard

RFC: 0-copy serialization / deserialization

14

I'm building an application that has a bunch of large (megabytes) probabilistic filters. However, I don't want to pay the bincode serialization / deserialization cost as it adds up quite...

vlovich

closes #82 some thougts: this is mainly useful for the hash_proxy so maybe it should just be implemented on that type specifically in addition to the generic Filter::contains()? the code...

djugei

contains should allow borrowed types

2

https://github.com/ayazhafiz/xorf/blob/108d67903f2df6db6dcd1c05c571594c529413d6/src/lib.rs#L119 it would be cool if one could query a `Filter` using `.contains(&T)` instead of `.contains(&Box)`. [std ](https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.contains_key) achieves this by using the Borrow Trait. this is a breaking change...

djugei

Use serde_bytes to reduce (de)serilization speed of 8-bit filters by 96%

3

I noticed that deserialization of the `BinaryFuse8` using serde takes a long time. In my use case with 450 millions members, it takes 2-3 minutes on a modern machine. The...

JanBerktold

Initial implementation as described in the RFC at #79

vlovich

Reproducible fingerprints

1

It would be nice to be able to reproduce fingerprints exactly! Right now the only configuration options are "initialize to 0" (reproducible) or "use the thread RNG" (not reproducible), but...

wirelyre

`BinaryFuse` filters only implement `TryFrom`, conflicting with `HashProxy`

2

Attempting to use a `HashProxy` is impossible in the current state due to `HashProxy::from` failing. You can reproduce by replacing `Xor8` with `BinaryFuse8` in the example. Output from cargo: ```...

ghost

Expose `prelude` helpers and `bfuse` struct fields

1

## What? In order to allow developers to be more fine-grained with their usage of this crate, I am proposing simply `pub` placements that I am currently using to expose...

ghost

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.7 to 3.3.1. Release notes Sourced from actions/cache's releases. v3.3.1 What's Changed Reduced download segment size to 128 MB and timeout to 10 minutes by @​kotewar in...

dependabot[bot]

`Contains` isn't O(1) with respect to the size of the filter?

1

I'm seeing something surprising - the performance of querying the filter seems to depend somewhat on how many elements are contained within the filter. Is that expected? I would have...

vlovich