Library Redefinition

[HoshinoTented]

Assume that:

• A library A, which defines prim I
• A library B, which depends on library A and defines nothing.
• A library C, which depends on library A and library B, also defines nothing.

Aya said:

Compiling A
  [Info] Resolving source file dependency
    Done in 158ms
  [Tyck] Prim (Prim.aya)
I like these modules :)
    Library loaded in 412ms
Compiling A
  [Info] Resolving source file dependency
    Done in 1ms
  [Tyck] Prim (Prim.aya)
In file Prim.aya:1:5 ->

  1 | prim I
           ^^

Error: Redefinition of primitive `I'

Resolving interrupted due to:
1 error(s), 0 warning(s).
🔨

See here for the complete information.

[mio-19]

😨

[mio-19]

A should be only compiled once by the way

[ice1000]

A should be only compiled once by the way

Yes, we do have that now.

[imkiva]

We should compute SCC of dependencies before compiling the library.

[HoshinoTented]

We should compute SCC of dependencies before compiling the library.

The libraries won't depend on each other, so topo sorting may be enough.

[ice1000]

We should compute SCC of dependencies before compiling the library.

The libraries won't depend on each other

Are you sure? What if they declare so?

[imkiva]

We should compute SCC of dependencies before compiling the library.

The libraries won't depend on each other, so topo sorting may be enough.

But this is indeed caused by library dependency. And topo sorting is surely a method that computes SCC.

[imkiva]

Just relax, I am taking care of this bug.

[HoshinoTented]

And topo sorting is surely a method that computes SCC.

That was amazing! I got it!

[ice1000]

Looks like it's closed by #978