Andrew Wilkins

Results 478 comments of Andrew Wilkins

We'll keep looking at this during 8.5 development, but won't actually turn it on by default until 8.6 - retargeting this.

I haven't updated CHANGELOG, as the bug hasn't made it into a release.

I'll merge this (after fixing the integration test) once the spec PR change is fully approved and merged.

Actually I'll merge this without waiting to avoid releasing with something that'll probably be taken away anyway.

> OK, depending on how the APM Server is / will handle those metrics, this information might be added already by the APM server from the agent metadata (i.e. agent-name)....

@gvencadze sorry for the silence, this slipped my attention. Can you please sign the CLA? As there are commits from multiple authors, both you and @EpicStep will need to do...

@gvencadze there's an issue with formatting, CI is failing with this error: ``` [2022-09-27T17:20:32.075Z] goimports differs: [2022-09-27T17:20:32.076Z] - module/apmpgx/e2e_test.go ``` Can you please make sure `make check-full` passes locally?