axunonb comments

Results 67 comments of


                                            axunonb

using plural with :p: token not working with version 3 (working in version 2 )

Please re-open if there's anything left to do.

#380 Add net 6 to System.Text.Json extension with conditional dependencies

@thompson-tomo Thanks! Please have a look at the failing build on appveyor for this PR.

#380 Add net 6 to System.Text.Json extension with conditional dependencies

Thanks for the fix. If we added net60, shouldn't this cover the main and all extension projects? We'll have a closer look during next days.

#380 Add net 6 to System.Text.Json extension with conditional dependencies

Adding NET60 as a target framework to only 1-2 projects is not enough. We're ready to go this step, but for all SmartFormat projects. Cysharp/ZString released v2.6.0 lately, which also...

#380 Add net 6 to System.Text.Json extension with conditional dependencies

We've created a [new branch v3.5.0](https://github.com/axuno/SmartFormat/tree/version/3.5.0). It already includes necessary changes to reference the Cysharp `ZString` Nuget package. To continue with this PR please rebase to this new branch. It...

#380 Add net 6 to System.Text.Json extension with conditional dependencies

LGTM, thanks for the PR and your initiative.

Phone number should be obligatory for team contacts

Enforcing a phone number might result in entering a fake number. So better convince the team contact to enter a phone number with a friendly reminder.