SmartFormat icon indicating copy to clipboard operation
SmartFormat copied to clipboard

Ignore bools in plurals formatter.

Open karljj1 opened this issue 3 years ago • 1 comments

I introduced a small bug in my last PR. The plurals formatter will now also consider bools which changes the behaviors when it is using auto detect. This was causing some of our tests to fail because we had an Arabic language running at the time which produces different plurals.

karljj1 avatar Aug 12 '22 13:08 karljj1

Codecov Report

Merging #306 (e125019) into main (ce9f034) will increase coverage by 0%. The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #306   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        91     91           
  Lines      3184   3186    +2     
===================================
+ Hits       3068   3070    +2     
  Misses      116    116           
Impacted Files Coverage Δ
...rtFormat/Extensions/PluralLocalizationFormatter.cs 89% <100%> (ø)
src/SmartFormat/SmartFormatter.cs 97% <0%> (ø)
src/SmartFormat/Core/Parsing/Format.cs 96% <0%> (ø)
src/SmartFormat/Core/Sources/Source.cs 100% <0%> (ø)
src/SmartFormat/Extensions/ListFormatter.cs 98% <0%> (+<1%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 12 '22 13:08 codecov[bot]