tcgone-engine-contrib
tcgone-engine-contrib copied to clipboard
Replace "it.dmg.value" with "it.notZero" for multiple damage modifiers applied before W/R, plus some other fixes in those code sections
When finished, should fix some issues with cards such as "Darkness Energy vs Metal Energy" in wizards formats, or "Professor Kukui vs Pressure/Intimidating_Fang" in recent formats.
Counts as a mass replacement, so leaving a checklist for looked-around gens:
- [x] Gen 1 [Groovy reimplementations]
- [x] Gen 2
- [x] Gen 3 [Sets in Groovy implementation]
- [x] Gen 4 [What's implemented here, DP-CL]
- [ ] Gen 5 [Cards using Groovy implementation]
- [ ] Gen 6 [Cards using Groovy implementation]
- [x] Gen 7
- [x] Gen 8
Sets not entirely fixable this way:
- Gen 1 [Legacy implementation]
- Gen 3 [Sets in Legacy implementation, RS-HL]
- Gen 5 [Effects that may use legacy code]
- Gen 6 [Effects that may use legacy code]
Hi @flagrama could you review this one please?
Turning into draft as there's now many gen 4 sets implemented, which may need updates in this regard.