tcgone-engine-contrib icon indicating copy to clipboard operation
tcgone-engine-contrib copied to clipboard

Start of massive refactor to set targets and source properly

Open flagrama opened this issue 1 year ago • 2 comments

TcgStatics changes show the changes that should be made to delayed effects to set targets and sources properly. I haven't really thought much about setting EffectTypes yet, but will probably work well in addition to the new event management.

The Unbroken Bonds STEALTHY_HOOD change shows how the new event management in the sister PR in the engine can be used to ensure we only block effects from abilities used by the opponent's Pokémon. Currently both resolvedTarget and thisPokemon are checked (all Groovy delayed checks extend AbstractDelayedMoveEffect so currently thisPokemon will work on more abilities this way for now, but once all abilities set their target

flagrama avatar Oct 09 '22 21:10 flagrama

@flagrama any updates on this?

axpendix avatar Oct 27 '22 19:10 axpendix

This is the sister PR to PR 204 in the engine repo. My questions over there pertain to this, but I'm discussing over there since the solution is going to require changes to the engine.

flagrama avatar Oct 29 '22 14:10 flagrama