tcgone-engine-contrib icon indicating copy to clipboard operation
tcgone-engine-contrib copied to clipboard

Published 20 hours ago • verified publisher icon axpendix

Implement Diamond and Pearl Trainer Kit

Open wertercatt opened this issue 2 years ago • 2 comments

This is technically part of the 2008 Standard Format. Mostly did this to ease myself back into working with the codebase though, if I'm honest.

wertercatt avatar Sep 21 '21 02:09 wertercatt

This needs to be added to src/tcgwars/logic/card/Collection.java as well. I also need to double check with the others if we need to have an equivalent https://github.com/tcgone/carddb set entry before it can be merged.

flagrama avatar Sep 21 '21 21:09 flagrama

If you are good with this as is I can merge it, however it needs to be added to Collection.java to show up on the Dev server and Play sandbox.

We also think it might be better to split the trainer kits into their own set files before that as that seems to be the norm (Bulbapedia, PTCGO) for the places that don't ignore it entirely (Pokemon.com, Pokemon TCG API).

As these aren't going to cause any errors it's up to you whether you want to do them in this PR or in another one after this is merged.

flagrama avatar Sep 22 '21 16:09 flagrama