cargo-dist icon indicating copy to clipboard operation
cargo-dist copied to clipboard

artifact-download-url customization

Open Gankra opened this issue 2 years ago • 2 comments

Currently we only support hardcoded support for github artifact download urls, which makes installers gated behind github. We can solve this by just letting the user specify. This should possibly support some amount of templating, as seen in the config for cargo-binstall.

It might also help github enterprise users.

Theoretical usecases:

  • artifact-download-url = "{repo}/releases/downloads/{tag}/" (what we currently do for github)
  • artifact-download-url = "https://mywebsite.com/{tag}/"

Exposing things like "app-name" and "app-version" are sketchier with workspaces but we can maybe allow them for single-app workspaces?

Gankra avatar May 03 '23 14:05 Gankra

interesting. this feels complicated- but complicated is fine if the end users are advanced. can we offer a way for an end user to validate/test what they've set up?

ashleygwilliams avatar May 03 '23 14:05 ashleygwilliams

Ideally this would use the same solution we pick for https://github.com/axodotdev/oranda/pull/507

Gankra avatar Jul 20 '23 16:07 Gankra