cargo-dist
cargo-dist copied to clipboard
`msvc-crt-static = false` has no effect
Hi, there's some issue with how you build the config graph.
Supplying a dist.toml with
[dist]
msvc-crt-static = false
Has no effect. No matter the value.
Reproduce
On windows with dist 0.28.0
-
cargo new foo - Set
authorsandrepositoryinCargo.toml -
git commit -am "initial" -
dist initand click through defaults -
dist init build --allow-dirt --print=linkage
You will get this output
┌────────────────────┬──────────────────────────────────┐
│ Category ┆ Libraries │
╞════════════════════╪══════════════════════════════════╡
│ System ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Homebrew ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Public (unmanaged) ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Frameworks ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Other ┆ KERNEL32.dll │
│ ┆ api-ms-win-core-synch-l1-2-0.dll │
│ ┆ ntdll.dll │
└────────────────────┴──────────────────────────────────┘
- Add
msvc-crt-static = falseat the end ofdist-workspace.tomlas described in the docs
You get the same output
- Change this line to always evaluate to false https://github.com/axodotdev/cargo-dist/blob/b96f4b7d6f3e9e5c36e25b08a63306df83d8893f/cargo-dist/src/build/cargo.rs#L94
-
dist init build --allow-dirt --print=linkage
Output:
┌────────────────────┬───────────────────────────────────┐
│ Category ┆ Libraries │
╞════════════════════╪═══════════════════════════════════╡
│ System ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Homebrew ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Public (unmanaged) ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Frameworks ┆ │
├╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┼╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌╌┤
│ Other ┆ KERNEL32.dll │
│ ┆ VCRUNTIME140.dll │
│ ┆ api-ms-win-core-synch-l1-2-0.dll │
│ ┆ api-ms-win-crt-heap-l1-1-0.dll │
│ ┆ api-ms-win-crt-locale-l1-1-0.dll │
│ ┆ api-ms-win-crt-math-l1-1-0.dll │
│ ┆ api-ms-win-crt-runtime-l1-1-0.dll │
│ ┆ api-ms-win-crt-stdio-l1-1-0.dll │
│ ┆ ntdll.dll │
└────────────────────┴───────────────────────────────────┘