cargo-dist icon indicating copy to clipboard operation
cargo-dist copied to clipboard

publish-prereleases = true only takes effect if publish jobs contains `npm` or `homebrew`

Open jackkleeman opened this issue 11 months ago • 0 comments

Currently the logic to determine if publish-prereleases = true makes it into the plan depends on the prerelease=true flag being set for both of the npm and homebrew v1 config blocks. If both of those are None, we default to false. However, its possible to have custom publish jobs which would also be skipped on prerelease. I feel that if both are None, we should still respect the value set in the dist config, if its set, before defaulting to false. I think this could be a breaking change, if there are custom publish jobs that users are expecting not to execute on prerelease.

jackkleeman avatar Feb 04 '25 18:02 jackkleeman