MoeList icon indicating copy to clipboard operation
MoeList copied to clipboard

[Minor] Keep the main characters on top of the character list

Open adarsh1001 opened this issue 1 year ago • 2 comments

Describe the bug (required) The characters list on the details page seems to be in random order. If it's not possible to follow the sort order of MAL (which is like based), I think we should at least display the main characters first.

To Reproduce Steps to reproduce the behavior:

  1. Open the app and search for "ore dake level up na ken".
  2. Open the details page for the anime and scroll down to Characters.
  3. The Main character is present towards the end of the list.
  4. For some anime with multiple main characters like in "Frieren", all main characters seem to be randomly distributed in the list.

Expected behavior For the Main characters to be present on top of the list.

Screenshots Screenshot_20240116-220123.png

Enviroment (required)

  • Device model: Nothing Phone (2)
  • Android version: 14
  • App version: 3.5.3

Additional context Possible to follow the MAL sort order? It's sorted by the number of likes on each character, though I believe this data is not exposed to the API. Screenshot_20240116-220403.png

adarsh1001 avatar Jan 16 '24 16:01 adarsh1001

Indeed the charcaters endpoint is not documented and probably under development so I can't do anything, that's why I marked it as beta.

Currently the only fields we can get are id,first_name,last_name,alternative_name,main_picture,biography.

Probably the API is sorting them by id

axiel7 avatar Jan 17 '24 02:01 axiel7

@axiel7 The "Main" or "Supporting" text that we render under the characters must also be coming from the API right? I was thinking if we can identify the Main ones and bring them in front of the list... Or is my understanding not correct? 😅

adarsh1001 avatar Jan 17 '24 05:01 adarsh1001