grunt-saucelabs icon indicating copy to clipboard operation
grunt-saucelabs copied to clipboard

500 response for DELETE stops test suite

Open Jonahss opened this issue 10 years ago • 2 comments

Every now and then a test fails, and the retry logic attempts to DELETE the failing test. And every so often, the DELETE command itself throws a 500 error.

In this case, grunt-saucelabs should just continue, and not halt.

Jonahss avatar Aug 22 '14 21:08 Jonahss

If grunt-saucelabs simply ignores the failed DELETE command then the failed saucelabs job will be probably preserved. This in turn will cause the saucelabs badge/status image to report the build as failed, in spite of the retry logic may have completed the test successfully. So I think grunt-saucelabs should repeat the DELETE command until it succeeds. It will be tricky to write tests for this.

gvas avatar Aug 26 '14 05:08 gvas

It might be the case that no matter how many retries are made, if the DELETE fails the job might not exist. I'm thinking that having your test suite complete is more important than the badge, since your build will still pass.

How about three retries, then continue with a warning in the log output. On Aug 25, 2014 10:56 PM, "Vas Gábor" [email protected] wrote:

If grunt-saucelabs simply ignores the failed DELETE command then the failed saucelabs job will be probably preserved. This in turn will cause the saucelabs badge/status image to report the build as failed, in spite of the retry logic may have completed the test successfully. So I think grunt-saucelabs should repeat the DELETE command until it succeeds. It will be tricky to write tests for this.

— Reply to this email directly or view it on GitHub https://github.com/axemclion/grunt-saucelabs/issues/160#issuecomment-53378494 .

Jonahss avatar Aug 26 '14 15:08 Jonahss