browser-perf icon indicating copy to clipboard operation
browser-perf copied to clipboard

Yarn installations

Open zanettin opened this issue 7 years ago • 4 comments

Hi

When we install browser-perf via Yarn, the "cleanup modules" tasks cleans up docs folder which is required that the code works as expected. Maybe you can rename the folder to ensure correct behaviour also for Yarn users?

Thanks a lot for this great tool! Cheers

zanettin avatar Aug 29 '17 07:08 zanettin

@zanettin Thanks for reporting the issue.

Are you using yarn clean and running into the issue ? Could you please help with repro steps ?

axemclion avatar Aug 30 '17 21:08 axemclion

Hi @axemclion

Yes exactly. yarn clean does that. Love this task and works quite great except for browser-perf on our react app 😄 What do you think?

Seams like this directories are removed:

docs
doc
website
images
assets

zanettin avatar Aug 31 '17 17:08 zanettin

@zanettin Do you suggest I rename docs to something else ? I could look to see if there is a way to not delete those folders.

axemclion avatar Sep 01 '17 04:09 axemclion

yes, if this is an option for you. listed folders from above are deleted by yarn clean. if you find another workaround/option it would also be great :-) thx

zanettin avatar Sep 01 '17 05:09 zanettin