Jason Axelson comments

Results 305 comments of


                                            Jason Axelson

Don't reset session on change_type

I've lost track of the code but I think that I modified the code locally and ran it.

Refactor and add support for Inky Impression 7.3"

> > I would have used the chip name instead of "original" but I haven't been able to find the name of the chip anywhere > > I did some...

Dependency on phoenix_ecto

Sure! Here you go: https://github.com/axelson/torch_repro_phoenix_ecto Yeah it isn't a common setup. In my actual project I generated an ecto-only project, then sometime later I decided I wanted a web frontend...

Dependency on phoenix_ecto

Yeah I'm definitely not suggesting to decouple Torch from Phoenix. Just mentioning a part of Phoenix that Torch depends on implicitly (and hoping to make it slightly more explicit).

Feature request: Affordances for asserting on js console output

Yeah that would be a great UX 👍

Allow to toggle full commit diff from within the diff view

I was going to suggest that it be added to the help section but now I see it is already in there `% :toggle file-filter`. My suggestion (which is counter...

Allow to toggle full commit diff from within the diff view

Also, thanks! This will be really helpful for my usage of tig. This was one of my largest nits. The other one was trying to go back in the history...

Confusing error message when test finishes before expectation is called

I am interested in creating a PR for this, I've started one but haven't finished it yet.

Confusing error message when test finishes before expectation is called

Thank you for the ping! I would still like to get to this but I haven't found the time yet.

Slightly confusing message when string key is mixed up for atom key

Yeah I'd like to, but no promises on when I'll get around to it. And thank you for the link to that snippet of code to get started.