liburing icon indicating copy to clipboard operation
liburing copied to clipboard

no way to enable high-level io_uring object

Open dankamongmen opened this issue 1 year ago • 7 comments

Unless I'm missing something (very possible), there's no way to enable the high-level io_uring object after using IOURING_SETUP_R_DISABLED. I'd like to implement io_uring_enable(3) unless this capability does already exist. Please let me know if you'd like a different name or anything.

Thanks for the great work on iouring!

dankamongmen avatar May 17 '23 05:05 dankamongmen

io_uring_enable_rings() exists for this, but looks like it hasn't been documented yet.

axboe avatar May 17 '23 15:05 axboe

i'll throw you a man page for it this evening unless you'd prefer to write it!

dankamongmen avatar May 17 '23 15:05 dankamongmen

Please do!

axboe avatar May 17 '23 16:05 axboe

the only error i see it returning is EBADFD. page looks to render correctly.

2023-05-31-090740_1453x618_scrot

dankamongmen avatar May 31 '23 13:05 dankamongmen

btw, since this function hasn't been in a release yet AFAIK, maybe s/rings/ring? unless there's something i'm missing.

dankamongmen avatar May 31 '23 13:05 dankamongmen

I think you could argue both ways on ring vs rings - there are two rings there, SQ and CQ. Both are effectively disabled, even though just having the SQ ring disabled obviously means that the CQ ring is too.

axboe avatar May 31 '23 14:05 axboe

btw, since this function hasn't been in a release yet AFAIK, maybe s/rings/ring? unless there's something i'm missing.

just fyi it's been there a long time - so can't update it now. since at least 2.0: https://github.com/axboe/liburing/blob/liburing-2.0/src/include/liburing.h#L144

DylanZA avatar Jun 01 '23 08:06 DylanZA