fio icon indicating copy to clipboard operation
fio copied to clipboard

sqthread_poll man page missing int flag

Open JonKohler opened this issue 5 years ago • 1 comments

On FIO 3.18, I tried to run this config (below) and got the following error.

The man page appears to be documented like it is FIO_OPT_STR_SET; however, the code is FIO_OPT_INT: https://fio.readthedocs.io/en/latest/fio_man.html#i-o-engine-specific-parameters

Is the man page wrong? or the code wrong? https://github.com/axboe/fio/blob/master/engines/io_uring.c#L151

Option sqthread_poll requires an argument fio: failed parsing sqthread_poll fio: job global dropped

[global]
ioengine=io_uring
fixedbufs
hipri
registerfiles
sqthread_poll
direct=1
time_based
norandommap
group_reporting
disk_util=0
continue_on_error=all
rate_process=poisson
bs=8k
rw=randread
iodepth=128

[db-disk1]
size=2G
filename=/dev/sdb

JonKohler avatar Feb 11 '20 02:02 JonKohler

@JonKohler I assume you are saying it needs to be clearer that you have to set sqthread_poll to a value (i.e. `sqthread_poll=1). If so I'd argue the documentation is unclear... would you care to submit a patch? You would need to fix fio.1 and the HOWTO...

sitsofe avatar May 10 '20 09:05 sitsofe

Fixed https://github.com/axboe/fio/commit/d6f936d1172a56c28b225d8a6858283d60d57f92

vincentkfu avatar Nov 04 '22 18:11 vincentkfu