Jens Axboe

Results 392 comments of Jens Axboe

> I will try this out over the weekend. I'll run some quick testing on this later, I'll post an updated version here if needed.

Pavel, outside of the patch being a quick'n dirty, the intent is _only_ to ignore O_NONBLOCK if set. We should not be fiddling with RWF_NOWAIT or ditto send/recvmsg flags. Just...

What you described, but only if O_NONBLOCK is set on the file. If you are setting request specific flags, like RWF_NOWAIT, then the -EAGAIN is returned as before. At that...

Two things from just a quick look: 1) We should not retain the old build system. If we're doing meson, we're going all the way 2) Exception to the above...

> provide a simple convenient make wrapper Ah that was already in the TODO, excellent.

> Should we test the meson build system with GitHub bot too? Most certainly.

> We should not retain the old build system. If we're doing meson, we're going all the way After pondering this some more, I do believe we should keep the...

Yes, that is deliberately left unused for now, it's so we can avoid adding Yet Another identical function when we do add flags for this.

I'd say keep the unused variables, but add annotations so we can do ```__maybe_unused``` to silence them. Then when they do get used, we can just remove that annotation.