Austin Wright

Results 325 comments of Austin Wright

> if you could compile a schema from the base schema and all of it's referenced schema into a single JSON object describing the entire schema Something like this would...

However, see https://github.com/tdegrunt/jsonschema#pre-property-validation-hook for some additional guidance on this.

The "default" property in JSON Schema doesn't have anything to do with actual validation, it's strictly informational. It's supposed to be used for things like creating new JSON documents from...

The test that @minettiandrea provided might have an insight, it looks like the "enum" keyword might incorrectly fail validation if it's set to null/undefined, as opposed to not existing.

The ABNF in the RFC doesn't technically allow for any whitespace, but the following paragraph says applications "may" (i.e. not MAY which is formally defined) use a space instead. I...

The proposed regex: ``` /^\d{4}-[0-1]{1}[0-9]{1}-[0-3]{1}[0-9]{1}[Tt]{0,1}[ ]{0,1}\d{2}:\d{2}:\d{2}((\.*\d{0,7}[Zz]{0,1}$)|(\.*\d{0,7}\+\d{0,2}:\d{0,2}$)|(\.*\d{0,7}$)|$|[Zz]{0,1}$)/ ``` fails the following example listed in RFC3339 itself: ``` 1996-12-19T16:39:57-08:00 ``` Additionally, instances of `{0,1}` and `{1}` can be shortened. My hand-crafted regex...

This seems reasonable. I'll play around with it a bit... I don't know why it would be so expensive, the majority of calls should be trivial to compute (where the...

I just saw this updated... I'm tagging it 'bug' because it can go out very next release, rather than being a feature enhancement that would bump the minor version number.

Right, `{type:"date"}` could continue to be supported, I don't think we'd even need to deprecate it; but in my usage it would raise as an invalid JSON Schema against the...

The next thing I would like too see is the formatting. Like if we could get a PR focused only on normalizing the whitespace, that would be great.