Brock Wilcox
Brock Wilcox
Ooops wrong PR. @cielf changes not addressed :)
I'm ok with this as-is and can help make sure that packs-#2 doesn't get confused based on the existing test data.
Looks good but I did fix a merge conflict; will approve/merge if that passes (or investigate otherwise).
Ah -- also from testing you need to add `config.hosts
RE the things-to-consider for superadmin -- `any route that a superadmin can reach (e.g. organization/show, partner/show)` -- are you talking about like `/admin/organization/232` paths, or something else they can get...
Looks like https://github.com/rubyforgood/human-essentials/blob/main/spec/rails_helper.rb#L157 adds this DEFAULT organization during test setup, so your test should assume that it exists.
Spec fails are unrelated, I'm fixing in main and will merge that in here for a clean bill of health :)
Nope :)
@aeisenberg thank you for the contribution! It'll likely take some practice, but I think it could really decrease the barrier-to-entry yet another notch for contributors.
NOTE -- Totally fine for this to be more than one pull request. It is good to have easy-to-review and deployable changes. We don't have to do it all in...