fastapi-crudrouter icon indicating copy to clipboard operation
fastapi-crudrouter copied to clipboard

Fix bugs that are not compatible with pydantic2.x

Open 0x587 opened this issue 1 year ago • 10 comments

I solved the problem that fastapi-crudrouter is not compatible with pydantic2.x, related issue #189, #190 The changes only involve fastapi_crudrouter/core/_utils.py

0x587 avatar Aug 17 '23 15:08 0x587

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fastapi-crudrouter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 0:10am

vercel[bot] avatar Aug 17 '23 15:08 vercel[bot]

Hey I was wandering around for this issue/pr and I appreciate your work! To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

cloudyyoung avatar Sep 13 '23 03:09 cloudyyoung

Hey I was wandering around for this issue/pr and I appreciate your work! To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

Thank you for your generous advice. Then I got some useful information from https://docs.pydantic.dev/2.3/migration/#changes-to-pydanticbasemodel which suggested me to use model_fields instead of __fields__. I will append these changes to my PR later.

0x587 avatar Sep 13 '23 10:09 0x587

Hi, everyone! Very interested in this release, as this library will really accelerate the development of a project I have just started. Reading the history, is something still missing to approve? I'd be glad to help.

marcelomendoncasoares avatar Oct 03 '23 18:10 marcelomendoncasoares

Is there any estimate for when this PR will be merged?

lohxx avatar Oct 24 '23 13:10 lohxx

I just added the missing import, and I'm really looking forward to seeing this PR merged. Thank help from @anthonypelletier

0x587 avatar Oct 24 '23 13:10 0x587

Okay, I have modified the location of the import. @awtkns

0x587 avatar Nov 01 '23 12:11 0x587

This is still an issue, will this patch be updated soon?

jofhanen avatar Dec 12 '23 22:12 jofhanen