spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

Introduce native support for config stores, core, SQS and SNS module

Open MatejNedic opened this issue 1 year ago • 10 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

Currently creating native image for using core, both configs, SQS and SNS work and polls on start of native executable. Closes #673 and partially #468

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [x] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] I updated reference documentation to reflect the change
  • [x] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

MatejNedic avatar Aug 01 '23 20:08 MatejNedic

@MatejNedic nice to see there's a movement towards native build support, are there any rough estimates when this PR will be merged?

romangr avatar Oct 17 '23 13:10 romangr

Hey hey @romangr , hopefully soon! Will work on this during a weekend

MatejNedic avatar Oct 19 '23 16:10 MatejNedic

@MatejNedic cool, thank you for your work!

romangr avatar Oct 19 '23 21:10 romangr

@maciejwalkowiak @tomazfernandes

Let merge this I have tested it and it works properly. We can always add hints when people report issues.

MatejNedic avatar Jun 17 '24 18:06 MatejNedic

Hey @MatejNedic and @maciejwalkowiak - just a heads up - there is a new version for AWS SDK V2 and AWS CRT which both supports Spring Boot Native, now - see: https://github.com/aws/aws-sdk-java-v2/pull/5290 / https://github.com/aws/aws-sdk-java-v2/pull/5184 and https://github.com/awslabs/aws-crt-java/pull/749

Can you bump the version of the AWS SDK V2 to a newer version?

This is important when you want to use the S3TransferManager to use Multipart-Uploads

klopfdreh avatar Jun 24 '24 04:06 klopfdreh

Hey @klopfdreh , Already updqted maven last week :)

MatejNedic avatar Jun 24 '24 06:06 MatejNedic

When this PR will be merged? 😄

Currently we have to take care of resource and everthing else like:

{
  "resources": [
    {
      "pattern": "io/awspring/cloud/core/SpringCloudClientConfiguration.properties"
    },
    {
      "pattern": "io/awspring/cloud/s3/S3ObjectContentTypeResolver.properties"
    }
  ]
}

and all other stuff you wrote hints for.

klopfdreh avatar Aug 01 '24 06:08 klopfdreh

@maciejwalkowiak lets merge this and release it in 3.2.0

MatejNedic avatar Aug 01 '24 08:08 MatejNedic

@MatejNedic , any reason why this is not compatible with 3.1.2?

meletis avatar Aug 01 '24 08:08 meletis