spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

Published 20 hours ago • verified publisher icon awspring

Standalone Init DynamoDb Clients

Open driverpt opened this issue 1 year ago • 6 comments

Type: Feature

Is your feature request related to a problem? Please describe. Currently the DynamoDb AutoConfiguration is conditional on DynamoDbTemplate.

Describe the solution you'd like Standalone Initialization of DynamoDb + Enhanced Clients without Depending on DynamoDbOperations and DynamoDbTemplate

Describe alternatives you've considered Copy+Paste all initialization Logic to our own @Configuration

Additional context N/A

driverpt avatar Apr 18 '23 12:04 driverpt

This would mean that DynamoDbTemplate bean is in a nested class in DynamoDbAutoConfiguration annotated with @ConditionalOnClass(DynamoDbTemplate.class).

I think it makes sense. Would you like to contribute a PR?

maciejwalkowiak avatar Apr 18 '23 12:04 maciejwalkowiak

Superseeded by #769

driverpt avatar Apr 18 '23 15:04 driverpt

@maciejwalkowiak , I would love to contribute with PR's. The question is, are you just going to reject them like you have previously done in the past ?

driverpt avatar Apr 18 '23 15:04 driverpt

You're welcome to contribute PRs.

The question is, are you just going to reject them like you have previously done in the past ?

Are you sure you want to start this conversation like that?

maciejwalkowiak avatar Apr 18 '23 15:04 maciejwalkowiak

I just want to know if it's worth that I spend my time creating a PR, that's all

driverpt avatar Apr 19 '23 16:04 driverpt

Start small with a PR for a single module. If it's good we will merge.

maciejwalkowiak avatar Apr 19 '23 17:04 maciejwalkowiak