spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

Published 20 hours ago • verified publisher icon awspring

AppConfig integration

Open MatejNedic opened this issue 2 years ago • 13 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

Still have to go through it once more time and add some docs. Tried against real AWS and all tests are passing. Since AWS Localstack has a bug it is not possible to make a real integration test. Closes #465

@eddumelendez SInce you worked on AppConfig integration before please when you have time check the design. I will do more cleaning and polishing of the code.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [x] I reviewed submitted code
  • [x] I added tests to verify changes
  • [x] I updated reference documentation to reflect the change
  • [x] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

MatejNedic avatar Aug 03 '22 16:08 MatejNedic

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Aug 03 '22 23:08 sonarqubecloud[bot]

What is holding this back? I'm waiting eagerly for this feature since months.

noshua avatar Mar 28 '23 13:03 noshua

Hey @noshua , it is planned go be tackled once 3.0.0 is released. There are some minor work to be done on this PR.

MatejNedic avatar Mar 28 '23 15:03 MatejNedic

It would be cool to include tests with localstack once is implemented -> https://github.com/localstack/localstack/issues/6891

MatejNedic avatar Jul 22 '23 19:07 MatejNedic

I'm also eagerly waiting for the feature. How can I help to get it integrated?

yurybubnov avatar Aug 30 '23 21:08 yurybubnov

any updates?

maxjiang153 avatar Oct 20 '23 02:10 maxjiang153

This feature would be awesome! Keeping an eye on this, and willing to help if needed.

mikelhamer avatar Oct 27 '23 20:10 mikelhamer

I feel like I must have missed it but can you clarify what happens when a new AppConfig HostedVersion gets pushed to the application and environment? Does it force a reload of the context?

NChitty avatar Oct 28 '23 12:10 NChitty

@MatejNedic Localstack implemented Appconfig support

maciejwalkowiak avatar Oct 28 '23 13:10 maciejwalkowiak

@maciejwalkowiak didn't know that perfect. Will implement with LocalStack tests and we can then hopefully merge and release. One more thing is that we will need to put LocalStack PRO credentials in GitHub pipeline

MatejNedic avatar Nov 01 '23 08:11 MatejNedic

Hey @NChitty , if you enable reload inside of integration it will periodically call AppConfig and do a reload or refresh depending on what you choose. It is covered by documentation.

MatejNedic avatar Nov 13 '23 18:11 MatejNedic

I don't wanna be rude, but over a year has passed by since my last status request. Is this feature dead before arrival?!

noshua avatar Apr 10 '24 11:04 noshua

Hey @noshua , I am thinking about redoing this integration. I have to rethink it, don't like current implementation can do more things will be exploring it.

MatejNedic avatar Apr 25 '24 21:04 MatejNedic