spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

SNS SMS support

Open MatejNedic opened this issue 2 years ago • 2 comments

:loudspeaker: Type of change

  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

This is currently just a draft how I vision Spring Cloud AWS support for sending SMS messages. Before I go further with tests @maciejwalkowiak please check design out.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [x] I reviewed submitted code
  • [x] I added tests to verify changes
  • [x] I updated reference documentation to reflect the change
  • [x] All tests passing
  • [x] No breaking changes

:crystal_ball: Next steps

MatejNedic avatar Jul 15 '22 17:07 MatejNedic

Will commit sample in following days

MatejNedic avatar Jul 21 '22 15:07 MatejNedic

Tried it against real AWS integration works as expected.

MatejNedic avatar Aug 31 '22 18:08 MatejNedic

Great job! Please add nullability annotations (including package-info.java) and javadocs on public classes & interfaces. Also, conflict has to be resolved.

maciejwalkowiak avatar Aug 31 '22 18:08 maciejwalkowiak

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 01 '22 14:09 sonarqubecloud[bot]