spring-cloud-aws icon indicating copy to clipboard operation
spring-cloud-aws copied to clipboard

fix issue with running Java 8

Open rajadilipkolli opened this issue 1 year ago • 1 comments

:loudspeaker: Type of change

  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring

:scroll: Description

After increasing the setup-java to v4, it needs distribution as a mandatory input parameter

:green_heart: How did you test it?

Ran the pipeline in my local and it is able to download the version and proceed further

:pencil: Checklist

  • [ ] I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] I updated reference documentation to reflect the change
  • [x] All tests passing
  • [x] No breaking changes

rajadilipkolli avatar Jan 08 '24 06:01 rajadilipkolli

Hi @maciejwalkowiak , Should the generate documentation step run against java 8? As the minimum java version used for this project is java 17. I feel we should increase here as well to Java 17

rajadilipkolli avatar Jan 08 '24 06:01 rajadilipkolli

@rajadilipkolli apologies for late reply. We should go with 17. But we also have to make a decision either we remove using SDKMan here, or we use version provided by SDKMan. I don't really have a strong opinion. @MatejNedic do you have any preference or good reason to use SDKMan in Github actions, considering all Java versions we need are available out of the box?

maciejwalkowiak avatar Mar 03 '24 23:03 maciejwalkowiak