yesiscan icon indicating copy to clipboard operation
yesiscan copied to clipboard

XDG is claimed to be used but doesn't follow the spec

Open ajorg-aws opened this issue 1 year ago • 3 comments

Comments in the code talk about XDG, and the default config path is said to be ~/.config/yesiscan/config.json but that path is configured relative to os.UserHomeDir() instead of following the XDG Base Directory Specification which would use the $XDG_CONFIG_HOME if set, and has other rules for deriving the path.

Recommend we either load configuration using a library that implements the spec, or avoid the appearance of XDG. It's probably safe to use ~/.config/ but not to imply that it's following XDG when it's not. The specification relates to a whole big design of mutable and immutable filesystems that we shouldn't claim to support if we don't.

ajorg-aws avatar Aug 31 '22 00:08 ajorg-aws