sockeye
sockeye copied to clipboard
Wrong parameter when creating vocabularies in sockeye.train.create_data_iters_and_vocabs
I think I found a bug in the sockeye.train.create_data_iters_and_vocabs function.
If I understand the code correctly, I suspect lines 388 and 390 should be:
source_factor_vocab_same_as_source=args.source_factors_use_source_vocab
and
target_factor_vocab_same_as_target=args.target_factors_use_target_vocab
,
rather than what they are now. (҂◡_◡)
Is that correct? Thanks! I.P.