sockeye icon indicating copy to clipboard operation
sockeye copied to clipboard

Wrong parameter when creating vocabularies in sockeye.train.create_data_iters_and_vocabs

Open iPRET opened this issue 9 months ago • 0 comments

I think I found a bug in the sockeye.train.create_data_iters_and_vocabs function.

If I understand the code correctly, I suspect lines 388 and 390 should be: source_factor_vocab_same_as_source=args.source_factors_use_source_vocab and target_factor_vocab_same_as_target=args.target_factors_use_target_vocab, rather than what they are now. (҂◡_◡) image

Is that correct? Thanks! I.P.

iPRET avatar May 31 '24 07:05 iPRET