sagemaker-debugger icon indicating copy to clipboard operation
sagemaker-debugger copied to clipboard

Update the Hook callback to be compatible with xgboost>1.3.0 callback style

Open haixiw opened this issue 2 years ago • 1 comments

from xgboost version 1.3.0 and later, all the callbacks taken by xgb.train() must be instances of xgb.callback.TrainingCallback https://xgboost.readthedocs.io/en/stable/python/python_api.html#callback-api From the usage : https://github.com/awslabs/sagemaker-debugger/blob/master/smdebug/xgboost/hook.py#L64 If we pass Hook together with other callbacks which are instances of xgb.callback.TrainingCallback, an Assert Error will happen because of the check here : https://github.com/dmlc/xgboost/blob/v1.5.2/python-package/xgboost/training.py#L62

haixiw avatar Aug 29 '22 21:08 haixiw

Reference: https://github.com/aws/sagemaker-xgboost-container/pull/301

mabunday avatar Sep 01 '22 14:09 mabunday

Issue should be fixed by PR:https://github.com/awslabs/sagemaker-debugger/pull/648 Closing.

yl-to avatar Feb 15 '23 00:02 yl-to