sagemaker-debugger icon indicating copy to clipboard operation
sagemaker-debugger copied to clipboard

Refactored MXNet/PyTorch/TF Exceptions, and End-of-training log directory check

Open jleeleee opened this issue 3 years ago • 0 comments

Description of changes:

Refactored all exception types under the smdebug/mxnet, smdebug/pytorch, and smdebug/tensorflow directories to return the SMDebugError exception type. Also changed the logic of the end of training log directory existence check in smdebug/core/hook_utils.py for the writer to return a boolean instead of raising an exception that gets caught later on, to make it clear that exceptions are generally meant to flow up to the customer, not to be used as a check.

Style and formatting:

I have run pre-commit install && pre-commit run --all-files to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jleeleee avatar Aug 22 '22 18:08 jleeleee