sagemaker-debugger icon indicating copy to clipboard operation
sagemaker-debugger copied to clipboard

[WIP]Test Custom Loss Module

Open NihalHarish opened this issue 5 years ago • 1 comments

Description of changes:

  • If the customer over-writes the forward pass function of a Loss module then ZCC has no effect.

Note: The first commit only reproduces the error and does not attempt to fix it.

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

NihalHarish avatar Oct 27 '20 00:10 NihalHarish

Codecov Report

Merging #388 into master will increase coverage by 1.41%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
+ Coverage   85.49%   86.91%   +1.41%     
==========================================
  Files          86       86              
  Lines        6514     6517       +3     
==========================================
+ Hits         5569     5664      +95     
+ Misses        945      853      -92     
Impacted Files Coverage Δ
smdebug/pytorch/hook.py 83.59% <100.00%> (+1.19%) :arrow_up:
smdebug/core/hook.py 93.88% <0.00%> (+0.39%) :arrow_up:
smdebug/core/save_config.py 88.80% <0.00%> (+0.79%) :arrow_up:
smdebug/core/tfevent/event_file_writer.py 97.50% <0.00%> (+1.25%) :arrow_up:
smdebug/core/access_layer/s3handler.py 69.53% <0.00%> (+1.32%) :arrow_up:
smdebug/core/utils.py 84.97% <0.00%> (+1.40%) :arrow_up:
smdebug/core/tfevent/events_writer.py 95.45% <0.00%> (+2.27%) :arrow_up:
smdebug/core/tfevent/index_file_writer.py 96.87% <0.00%> (+3.12%) :arrow_up:
smdebug/mxnet/collection.py 80.00% <0.00%> (+3.33%) :arrow_up:
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 311a6f4...c1dd8d1. Read the comment docs.

codecov-io avatar Oct 27 '20 02:10 codecov-io