sagemaker-debugger icon indicating copy to clipboard operation
sagemaker-debugger copied to clipboard

Save Nested Layers For Rubik

Open NihalHarish opened this issue 5 years ago • 1 comments

Description of changes:

  • This PR is in the draft stage, I need to update tests, refactor and add comments.
  • Adds ability to save nested layers with the use of the _flatten_layers API. See tests/tensorflow2/test_nested_layers.py
  • Adds the ability to save repeated calls to the same layer object with model subclassing by storing the outputs of the layers in a list in the InputOutputSaver object. See tests/tensorflow2/test_model_that_reuses_layers.py
  • Creates a unique name for each layer output and input to make it more intuitive for the user. See tests/tensorflow2/test_concat_layer.py

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

NihalHarish avatar Oct 19 '20 21:10 NihalHarish

Codecov Report

Merging #377 into master will decrease coverage by 2.72%. The diff coverage is 98.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   85.49%   82.76%   -2.73%     
==========================================
  Files          86       86              
  Lines        6514     6539      +25     
==========================================
- Hits         5569     5412     -157     
- Misses        945     1127     +182     
Impacted Files Coverage Δ
smdebug/tensorflow/keras.py 80.03% <97.77%> (-12.29%) :arrow_down:
smdebug/tensorflow/utils.py 63.45% <100.00%> (-24.88%) :arrow_down:
smdebug/tensorflow/singleton_utils.py 83.33% <0.00%> (-16.67%) :arrow_down:
smdebug/tensorflow/callable_cache.py 69.56% <0.00%> (-13.05%) :arrow_down:
smdebug/tensorflow/collection.py 84.53% <0.00%> (-11.35%) :arrow_down:
smdebug/tensorflow/tensor_ref.py 82.25% <0.00%> (-6.46%) :arrow_down:
smdebug/tensorflow/base_hook.py 76.19% <0.00%> (-4.37%) :arrow_down:
smdebug/tensorflow/session.py 88.46% <0.00%> (-3.37%) :arrow_down:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 311a6f4...6826d4b. Read the comment docs.

codecov-io avatar Oct 19 '20 22:10 codecov-io