sagemaker-debugger icon indicating copy to clipboard operation
sagemaker-debugger copied to clipboard

Adding filtering node logic issue:321

Open Vikas-kum opened this issue 5 years ago • 2 comments

Issue: https://github.com/awslabs/sagemaker-debugger/issues/321

Description of changes:

Adding filtering logic to dest_names and make sure that we always ask for subgraph which is present in graph def

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Vikas-kum avatar Aug 11 '20 01:08 Vikas-kum

Codecov Report

Merging #324 into master will decrease coverage by 2.81%. The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   85.29%   82.47%   -2.82%     
==========================================
  Files          86       86              
  Lines        6352     6369      +17     
==========================================
- Hits         5418     5253     -165     
- Misses        934     1116     +182     
Impacted Files Coverage Δ
smdebug/tensorflow/session.py 90.36% <55.55%> (-1.50%) :arrow_down:
smdebug/tensorflow/collection.py 95.23% <90.00%> (-0.64%) :arrow_down:
smdebug/pytorch/__init__.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/pytorch/singleton_utils.py 0.00% <0.00%> (-100.00%) :arrow_down:
smdebug/pytorch/collection.py 0.00% <0.00%> (-90.00%) :arrow_down:
smdebug/pytorch/hook.py 0.00% <0.00%> (-80.33%) :arrow_down:
smdebug/pytorch/utils.py 0.00% <0.00%> (-43.59%) :arrow_down:
smdebug/rules/action/stop_training_action.py 61.53% <0.00%> (-15.39%) :arrow_down:
smdebug/rules/req_tensors.py 79.16% <0.00%> (-11.12%) :arrow_down:
smdebug/core/tfevent/util.py 83.87% <0.00%> (-6.46%) :arrow_down:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e38f381...9ac01ae. Read the comment docs.

codecov-commenter avatar Aug 11 '20 01:08 codecov-commenter

Codecov Report

Merging #324 into master will decrease coverage by 1.60%. The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   87.06%   85.45%   -1.61%     
==========================================
  Files          86       86              
  Lines        6507     6524      +17     
==========================================
- Hits         5665     5575      -90     
- Misses        842      949     +107     
Impacted Files Coverage Δ
smdebug/tensorflow/session.py 90.32% <55.55%> (-1.51%) :arrow_down:
smdebug/tensorflow/collection.py 95.23% <90.00%> (-0.64%) :arrow_down:
smdebug/mxnet/graph.py 25.80% <0.00%> (-64.52%) :arrow_down:
smdebug/core/access_layer/base.py 64.28% <0.00%> (-21.43%) :arrow_down:
smdebug/core/modes.py 55.00% <0.00%> (-15.00%) :arrow_down:
smdebug/core/access_layer/utils.py 77.27% <0.00%> (-13.64%) :arrow_down:
smdebug/mxnet/collection.py 76.66% <0.00%> (-13.34%) :arrow_down:
smdebug/core/logger.py 66.12% <0.00%> (-12.91%) :arrow_down:
smdebug/core/tfrecord/record_reader.py 78.00% <0.00%> (-12.00%) :arrow_down:
smdebug/exceptions.py 67.53% <0.00%> (-6.50%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7470da7...c4c8efe. Read the comment docs.

codecov-io avatar Oct 21 '20 19:10 codecov-io