awslabs
Reduce ZCC Runtimes
Description of changes:
- This PR reduces the runtime of the ZCC unit tests
- We should ideally move save_all tests to nightly
Style and formatting:
I have run pre-commit install to ensure that auto-formatting happens with every commit.
Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Codecov Report
Merging #315 into master will decrease coverage by
2.80%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 84.36% 81.56% -2.81%
==========================================
Files 86 86
Lines 6352 6352
==========================================
- Hits 5359 5181 -178
- Misses 993 1171 +178
| Impacted Files | Coverage Δ | |
|---|---|---|
| smdebug/pytorch/__init__.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| smdebug/pytorch/singleton_utils.py | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
| smdebug/pytorch/collection.py | 0.00% <0.00%> (-90.00%) |
:arrow_down: |
| smdebug/pytorch/hook.py | 0.00% <0.00%> (-80.33%) |
:arrow_down: |
| smdebug/pytorch/utils.py | 0.00% <0.00%> (-43.59%) |
:arrow_down: |
| smdebug/rules/action/stop_training_action.py | 61.53% <0.00%> (-15.39%) |
:arrow_down: |
| smdebug/rules/req_tensors.py | 79.16% <0.00%> (-11.12%) |
:arrow_down: |
| smdebug/core/tfevent/util.py | 83.87% <0.00%> (-6.46%) |
:arrow_down: |
| smdebug/tensorflow/callable_cache.py | 78.26% <0.00%> (-4.35%) |
:arrow_down: |
| smdebug/rules/action/action.py | 91.83% <0.00%> (-4.09%) |
:arrow_down: |
| ... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update edc8499...754d9b6. Read the comment docs.
Leaving this PR open. The performance concern was addressed in
https://github.com/awslabs/sagemaker-debugger/pull/316
