awslabs
refactor: move crypto and llrt to llrt_modules
Description of changes
Moving crypto and llrt to llrt_modules. However, the creation of types is just the beginning...
Checklist
- [x] Created unit tests in
tests/unitand/or in Rust for my feature if needed - [x] Ran
make fixto format JS and apply Clippy auto fixes - [x] Made sure my code didn't add any additional warnings:
make check - [x] Added relevant type info in
types/directory - [x] Updated documentation if needed (API.md/README.md/Other)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Could use a different naming than llrt even if it is importable by default as llrt:something. Same idea that we dont have a module called node. Instead we could use the tag system I proposed to mark the source of those APIs.
Could use a different naming than
llrteven if it is importable by default asllrt:something. Same idea that we dont have a module called node. Instead we could use the tag system I proposed to mark the source of those APIs.
Hi @Sytten , Thank you for your comment.
What other uses exist besides importing with the designation llrt:something? Also, for your proposed tag system, if it is already in use somewhere in this project, could you please tell me where?
Sorry, I don't have English and technical skills and would appreciate your time and tips to help me understand your thoughts. :)
I will speak with @richarddavison about it, dont worry about it. I would split the PR to port crypto first since there is not debate around that one and lets postpone the llrt module transfer.
I will speak with @richarddavison about it, dont worry about it. I would split the PR to port crypto first since there is not debate around that one and lets postpone the llrt module transfer.
Thank you for your consideration. There was a place in the crypto module that used llrt:uuid, so I had no choice but to move it at the same time...
I have just finished creating all the types as well, so I will leave this PR as it is.
I wanted to clean up this PR quickly, so I modified the move to llrt_modules to only use the crypto module. It was only a small part of the crypto module's dependency on llrt:uuid, so we decided to use the uuid crate directly.