kubeflow-manifests icon indicating copy to clipboard operation
kubeflow-manifests copied to clipboard

Unit-tests for each deployment option

Open ryansteakley opened this issue 2 years ago • 3 comments

Description of your changes: Adds unit-tests for each AWS Kubeflow-manifests deployment option.

  • Added in generate_tests.py Additional PR on the way which adds enhancement for substitutions of fields such as those supplied to params.env

Made modifications to test_util.go to run unit-tests as caching system relied on just metadata name and kind but unit-tests would fail since k-eventing and k-serving both have the same metadata name and kind.

  • Added namespace to the key that is constructed as well

Testing:

  • [x] Unit tests pass Screen Shot 2022-03-30 at 7 23 37 PM

  • [ ] e2e tests pass

  • Details about new tests (If this PR adds a new feature)

  • Details about any manual tests performed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ryansteakley avatar Mar 30 '22 15:03 ryansteakley

Intimidating PR, can you link where this unit test is coming from and result of test run/log?

goswamig avatar Mar 31 '22 00:03 goswamig

Intimidating PR, can you link where this unit test is coming from and result of test run/log?

Hey these unit-tests are generated by test_util.go so they have not existed prior.

ryansteakley avatar Mar 31 '22 02:03 ryansteakley

Discussed having parametrized tests for components which have params.env and only check the kustomize file builds for each deployment option since the validation is not maintainable by this group. This is because many components are being consumed as is from upstream. We will focus on validating AWS managed overlays and components

surajkota avatar Apr 14 '22 01:04 surajkota

Reopen PR when ready

surajkota avatar Oct 12 '22 21:10 surajkota