iot-app-kit icon indicating copy to clipboard operation
iot-app-kit copied to clipboard

chore(scene composer): addressing react-hook linter warnings

Open mumanity opened this issue 9 months ago • 1 comments

Overview

Addressing a portion of the linter warnings from the implementation of react-hook linter on Scene Composer. Takes us from 712 to 672 warnings.

Updates include:

  • Removing unused imports
  • Removing unused dependencies in hooks
  • Adding missing dependencies in hooks to prevent infinite loops & ensure accurate executions

Verifying Changes

Scene Composer

For scene-composer package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for the Publish Storybook action to complete below.

  • Click on the workflow details
  • Select the Summary item on the left
  • Download the zip file

To run the storybook build locally, you need a local static web server:

npm install -g httpserver
cd <Extracted Zip Directory>
httpserver

Then open the website http://localhost:8080 to run the doc site.

Legal

This project is available under the Apache 2.0 License.

mumanity avatar May 08 '24 22:05 mumanity

Did you manually update these or did you use the linter to auto-fix the warnings?

hwandersman avatar May 09 '24 16:05 hwandersman