goformation icon indicating copy to clipboard operation
goformation copied to clipboard
verified publisher icon awslabs

No pointers in generated Slice (/List) and Map

Open daemonl opened this issue 3 years ago • 4 comments

Issue #, if available:, #493

Description of changes:

  • Change the generator to skip the pointer * for List and Map types
  • Minor refactor to keep the template IF statement under control with the extra logic

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

daemonl avatar Sep 17 '22 03:09 daemonl

Hi @daemonl ! This is awesome work. Let's try to make all tests pass and I think I'll release a new major version v7 after we merge this. Can't thank you enough!

rubenfonseca avatar Sep 19 '22 13:09 rubenfonseca

@daemonl do you have bandwidth to look and fix the tests?

rubenfonseca avatar Sep 19 '22 13:09 rubenfonseca

I am looking in to them - some I don't quite follow so I may have to get it close and let someone more familiar make some decisions

daemonl avatar Sep 19 '22 21:09 daemonl

See #496 for a version where the feedback is applied at the commits where the issues were created

daemonl avatar Sep 22 '22 07:09 daemonl